Repository navigation
fix(campaign): classify verification failures as sanity - #37
Merged
Merged
Conversation
A profile verification command that failed with an Lmod "error:" line was classed as compile, because the generic "error:" test came before the verify-stage fallback to sanity, which was never reached. reference/campaigns.org maps a failed verification command to sanity. Nothing is fetched, patched, configured, compiled, linked or installed while a verification command runs, so after the target-side classes (transport, executor, resource, runtime) and the robot classes a verify-stage failure is now timeout or sanity. The finding summary printed the exit code with Rust debug formatting, "exit Some(1)", and every history line named the class the same way, "as Compile" or "as DependencyMissing", where the state file says "compile" and "dependency-missing". BuildFindingClass now displays as its serde name, and the verification summary uses the exit-status text the build summary already used. Tests: the classifier on recorded Lmod and Python output for the verify stage, and campaigns whose verification command or EasyBuild command fails, checked for class, summary and history wording.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed verification command is a
sanityfinding, ortimeout, and findings no longer print Rust debug text such asexit Some(1).error:line was classed as compile, because the genericerror:test came before the verify-stage fallback to sanity.reference/campaigns.orgmaps a failed verification command to sanity. After the target-side classes (transport, executor, resource, runtime) and the robot classes, a verify-stage failure is now timeout or sanity.exit Some(1), and history lines named the class asCompileorDependencyMissing, where the state file sayscompileanddependency-missing.BuildFindingClassnow displays as its serde name, and the verification summary uses the exit-status text the build summary already used.a_failed_verification_command_is_a_sanity_finding,a_failed_verification_finding_reads_the_way_the_state_file_spells_itanda_failed_build_names_its_class_the_way_the_state_file_doescover those. The commit has a towncrier fragment. Main has no towncrier yet; #26 (fix/towncrier) adds it.